iritmaximus/oodikone
1
0
Fork 0
mirror of https://github.com/UniversityOfHelsinkiCS/oodikone.git synced 2026-10-12 19:03:39 +03:00
Code Issues Packages Projects Releases Wiki Activity

[ProgrammeOverview][ProgrammeCourses] Remove 95% of (duplicate) 'Not completed' entries

Browse Source
This commit is contained in:
Aaro Koivukangas
2026-06-15 15:33:03 +03:00
parent 5359eae68d
commit deaa41565d
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
services/backend/src/services/studyProgramme/index.ts
+5 -4
View File
@@ -27,7 +27,7 @@ export const getAllProgrammeCourses = async (providerCode: string) => {
return courses
}
const getCourseCode = (code: string) => {
const removeOpenUniCodePrefix = (code: string) => {
if (code.startsWith('AY')) {
return code.replace('AY', '')
}
@@ -40,6 +40,7 @@ const getCourseCode = (code: string) => {
export const getNotCompletedForProgrammeCourses = async (from: Date, to: Date, programmeCourses: string[]) => {
try {
const enrollmentsCourses = await EnrollmentModel.findAll({
raw: true,
attributes: ['studentnumber', 'course_code'],
where: {
course_code: {
@@ -54,7 +55,7 @@ export const getNotCompletedForProgrammeCourses = async (from: Date, to: Date, p
const allEnrollments = new Map<string, Set<string>>()
for (const { studentnumber, course_code: courseCode } of enrollmentsCourses) {
const code = getCourseCode(courseCode)
const code = removeOpenUniCodePrefix(courseCode)
if (!allEnrollments.has(code)) {
allEnrollments.set(code, new Set())
}
@@ -86,7 +87,7 @@ export const getNotCompletedForProgrammeCourses = async (from: Date, to: Date, p
}, new Map())
const creditCourses = credits.map(credit => ({
code: getCourseCode(credit.course_code),
code: removeOpenUniCodePrefix(credit.course_code),
studentNumber: credit.student_studentnumber,
creditTypeCode: credit.credittypecode,
courseName: courseCodeToName.get(credit.course_code)!,
@@ -117,7 +118,7 @@ export const getNotCompletedForProgrammeCourses = async (from: Date, to: Date, p
// If student has enrollments, but no attainment for a particular course, they have no credit info.
programmeCourses.forEach(courseCode => {
allEnrollments.get(courseCode)?.forEach(studentnumber => {
if (passedByCourseCodes.get(courseCode)?.has(studentnumber)) {
if (!passedByCourseCodes.get(courseCode)?.has(studentnumber)) {
notCompletedByCourseCodes.get(courseCode)?.add(studentnumber)
}
})