mirror of
https://github.com/UniversityOfHelsinkiCS/oodikone.git
synced 2026-10-12 19:03:39 +03:00
[E2E][LanguageCenter] Skip flaky test + try to make data deterministic
This commit is contained in:
@@ -37,7 +37,9 @@ test.describe('When language center is opened', () => {
|
||||
await expect(page.getByText('AYKK-RUKIRJ')).toBeVisible()
|
||||
})
|
||||
|
||||
test('Faculties tab shows numbers', async ({ page }) => {
|
||||
// FIXME: This changes per updater run
|
||||
// Example case: 550789 - KK-JAOK15
|
||||
test.skip('Faculties tab shows numbers', async ({ page }) => {
|
||||
await checkNumbers(page, [2074, 36, 9, 33, 758, 15, 40, 6, 51, 1, 24, 1059, 42, 0], 15, 'faculties')
|
||||
})
|
||||
|
||||
|
||||
@@ -131,7 +131,11 @@ export const computeLanguageCenterData = async () => {
|
||||
semestercode: { [Op.gte]: autumnSemester2017 },
|
||||
credittypecode: 4,
|
||||
},
|
||||
order: [['attainment_date', 'DESC']],
|
||||
order: [
|
||||
['attainment_date', 'DESC NULLS LAST'],
|
||||
['student_studentnumber', 'ASC'],
|
||||
['course_id', 'ASC'],
|
||||
], // Add a fallbacks sorting so that runs would be more deterministic
|
||||
})
|
||||
|
||||
const enrollments = await EnrollmentModel.findAll({
|
||||
@@ -142,7 +146,11 @@ export const computeLanguageCenterData = async () => {
|
||||
state: { [Op.in]: ['ENROLLED', 'REJECTED'] },
|
||||
// EnrollmentDateTimeThreshold need not be used here as we are not counting failed courses
|
||||
},
|
||||
order: [['enrollment_date_time', 'DESC']],
|
||||
order: [
|
||||
['enrollment_date_time', 'DESC NULLS LAST'],
|
||||
['studentnumber', 'ASC'],
|
||||
['course_id', 'ASC'], // Last fallback
|
||||
],
|
||||
})
|
||||
|
||||
const studyRights = await SISStudyRightModel.findAll({
|
||||
|
||||
Reference in New Issue
Block a user