skip fucked up students in studyright diff

services/backend/oodikone2-backend/src/sisoodi_diff/populations.js

@@ -17,6 +17,21 @@ let allfakd = []
 */
 
 const ignores = {
+  KH10_001: {
+    2017: {
+      oodi: ['014816167'] // on tohtoriopiskelija, mutta kandioikeus jätetty oodissa voimaan
+    },
+    2020: {
+      oodi: ['011725361'] // https://github.com/UniversityOfHelsinkiCS/oodikone/issues/2786
+    }
+  },
+  KH20_001: {
+    2020: {
+      sis: [
+        '014472190', '014709698' // mistakenly missing from oodi-oodikone
+      ]
+    }
+  },
   KH40_001: {
     2020: {
       oodi: ['014290314'] // Oodissa on virhe opintoajan pituuden laskussa. Tämä on tullut äskettäin ilmi. Sisussa on siis oikeat tiedot.
@@ -32,11 +47,26 @@ const ignores = {
       sis: ['015340182'] // studyright enddate missing in sis https://github.com/UniversityOfHelsinkiCS/oodikone/issues/2701
     }
   },
+  KH40_004: {
+    2020: {
+      sis: ['011516143'] // ei läsnä syksyllä, puuttuu ehkä siksi oodista?
+    }
+  },
   KH40_005: {
     2018: {
       sis: ['014650093'] // on tosiaan vähän ristiriitaiset tiedot Oodissa. Sisussa näkyy kuitenkin ok, niin että annetaan olla
     }
   },
+  KH40_006: {
+    2020: {
+      oodi: ['013919638'] // https://github.com/UniversityOfHelsinkiCS/oodikone/issues/2786
+    }
+  },
+  KH50_001: {
+    2020: {
+      oodi:['013470384']  // https://github.com/UniversityOfHelsinkiCS/oodikone/issues/2786
+    }
+  },
   KH50_004: {
     2020: {
       oodi: ['013881465'] // studyright enddate too early in sis https://github.com/UniversityOfHelsinkiCS/oodikone/issues/2701
@@ -45,6 +75,9 @@ const ignores = {
   KH74_001: {
     2019: {
       sis: ['014480768'] // graduation missing in oodi https://github.com/UniversityOfHelsinkiCS/oodikone/issues/2705
+    },
+    2020: {
+      sis: ['014614071', '013497370' ] // missing from oodi-oodikone perhaps due to missing läsnäolo for suksy
     }
   },
   KH57_002: {
@@ -75,7 +108,8 @@ const ignores = {
         '014711262',
         '014721825',
         '014528934',
-        '014659133'
+        '014659133',
+        '014845154' // studyright enddate too early in sis https://github.com/UniversityOfHelsinkiCS/oodikone/issues/2787
       ]
     },
     2018:{ // varhaiskasvatus https://github.com/UniversityOfHelsinkiCS/oodikone/issues/2738
@@ -104,7 +138,19 @@ const ignores = {
         '013743299',
         '013758239',
         '014590807',
-      ]
+        '013495071' // studyright enddate too early in sis https://github.com/UniversityOfHelsinkiCS/oodikone/issues/2787
+      ],
+      sis: ['014734511'] // https://github.com/UniversityOfHelsinkiCS/oodikone/issues/2790 also a varhaiskasvatus issue
+    }
+  },
+  MH10_001: {
+    2020: {
+      sis: ['012334670']
+    }
+  },
+  MH40_009: {
+    2020: {
+      sis: ['010951408']
     }
   },
   // there are many inconsistencies in masters, so they're grouped by the reason, not

updater/sis-updater-worker/src/updater/updateStudents/index.js

@@ -83,6 +83,10 @@ const updateStudents = async personIds => {
   // grouping in function that sets first_snapshot_date_time
   const groupedStudyRightSnapshots = groupStudyrightSnapshots(degreeStudyRightSnapshots)
 
+  console.log('**')
+  console.log(JSON.stringify(groupedStudyRightSnapshots, null , 2))
+  console.log(groupedStudyRightSnapshots["hy-opinoik-96550693"].map(s => s.modification_ordinal))
+
   const latestStudyRights = Object.values(groupedStudyRightSnapshots).reduce((acc, curr) => {
     acc.push(curr[0])
     return acc

updater/sis-updater-worker/src/updater/updateStudents/studyRightUpdaters.js

@@ -9,7 +9,6 @@ const { selectFromByIds, bulkCreate } = require('../../db')
 const { getDegrees, getEducation, getEducationType } = require('../shared') // not all of these are really shared,
 // e.g. getDegrees, getEducationType is only used here, refactor?
 
-
 const updateStudyRights = async (studyRights, personIdToStudentNumber, personIdToStudyRightIdToPrimality) => {
   const mapStudyright = studyrightMapper(personIdToStudentNumber)