iritmaximus/nowdatabase
1
0
Fork 0
mirror of https://github.com/nowcommunity/nowdatabase.git synced 2026-10-12 19:13:52 +03:00
Code Issues Packages Projects Releases Wiki Activity

Clarify reference validation label mapping

Browse Source
This commit is contained in:
Kari Lintulaakso
2025-12-15 17:57:59 +02:00
parent d1e3988d32
commit bc11fc4ae1
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
documentation/reference-validation-messages.md
+4 -4
View File
@@ -2,11 +2,11 @@
## Grouped required-field errors
- The string `"At least one of the following fields is required: …"` is produced in `orCheck` inside `frontend/src/shared/validators/reference.ts`.
- `orCheck` builds the list of field keys based on `ref_type_id` and checks whether any of those fields contain a non-empty string. When none do, it returns the concatenated message with the raw field names.
- `orCheck` builds the list of field keys based on `ref_type_id` and checks whether any of those fields contain a non-empty string. When none do, it returns the concatenated message.
- `validateReference` wires `orCheck` into the validators for `title_primary`, `title_secondary`, `title_series`, and `gen_notes`, so the message appears both in inline errors and aggregate validation results.
## Display labels for reference fields
- Human-readable labels per reference type come from the database table `ref_field_name` (via Prisma model `ref_field_name`), which stores `ref_field_name` (display text) alongside `field_name` (schema key) scoped by `ref_type_id`.
- The backend returns these labels through `getReferenceTypes` in `backend/src/services/reference.ts`, which fetches `ref_ref_type` records including their `ref_field_name` children.
- On the frontend, `ReferenceTab` (`frontend/src/components/Reference/Tabs/ReferenceTab.tsx`) reads `selectedRefType.ref_field_name` to render form controls with the per-type display labels (e.g., `field.ref_field_name`).
- These labels currently are not reused by the validator when constructing the grouped required-field message; the message still uses the raw field keys from `orCheck`.
- The backend returns these labels through `getReferenceTypes` in `backend/src/services/reference.ts`, which fetches `ref_ref_type` records including their `ref_field_name` children, and `buildReferenceDisplayLabelMap` converts them into a lookup keyed by `ref_type_id`.
- `validateEntireReference` passes this `displayLabelMap` into `validateReference`, enabling `orCheck` to swap field keys for per-type display labels when building the grouped required-field message.
- On the frontend, `ReferenceDetails` injects the same display-label map into `validateReference` so both inline and aggregate messages show labels like "Title", "Organisation", or "Notes" instead of raw schema keys for the active reference type.