iritmaximus/workh
1
0
Fork 0
mirror of https://github.com/iritmaximus/workh.git synced 2026-10-12 19:13:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

[RateLimiter] Remove ratelimiter to stop service from being unavailable

Browse Source
This commit is contained in:
Aaro Koivukangas
2026-10-11 12:11:01 +03:00
parent 584f5213e6
commit 42f274b394
8 changed files with 6 additions and 173 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/auth.spec.ts
-12
View File
@@ -106,18 +106,6 @@ test.describe('log in / log out', () => {
await expect(page.getByLabel('Password')).toHaveValue('');
});
test('ten wrong passwords lock the client out, even with the right one', async ({ page, user }) => {
await page.request.post('/api/logout', { data: {} });
for (let i = 0; i < 10; i++) {
await page.request.post('/api/login', { data: { username: user.username, password: 'wrong guess' } });
}
await page.goto('/');
await page.getByLabel('Username').fill(user.username);
await page.getByLabel('Password').fill(user.password);
await page.getByRole('button', { name: 'Log in' }).click();
await expect(page.getByRole('alert')).toContainText('Too many failed logins');
});
test('logging out right after typing still saves the change', async ({ page, user }) => {
await page.goto('/');
await dayInput(page, MONDAY).fill('7:15');
e2e/fixtures.ts
+3 -15
View File
@@ -17,15 +17,6 @@ export function uniqueName(prefix = 'u'): string {
return `${prefix}${process.pid.toString(36)}${(counter++).toString(36)}${Math.random().toString(36).slice(2, 7)}`;
}
/**
* A made-up client address. The server trusts X-Forwarded-For from loopback (like it trusts
* Traefik in the cluster), so each test is a separate client for the per-IP rate limits.
*/
export function randomIp(): string {
const b = () => Math.floor(Math.random() * 254) + 1;
return `10.${b()}.${b()}.${b()}`;
}
// Accounts created by the running test; deleted afterwards so the servers never reach
// their account limit (MAX_USERS), however often the suite runs.
const created: { creds: Creds; baseURL: string }[] = [];
@@ -45,7 +36,7 @@ export async function registerViaApi(request: APIRequestContext, creds: Creds) {
// test's trace recording.
async function deleteCreated() {
for (const { creds, baseURL } of created.splice(0)) {
const headers = { 'Content-Type': 'application/json', 'X-Forwarded-For': randomIp() };
const headers = { 'Content-Type': 'application/json' };
const login = await fetch(`${baseURL}/api/login`, { method: 'POST', headers, body: JSON.stringify(creds) });
if (!login.ok) continue; // already deleted by the test, or never finished signing up
const cookie = login.headers.get('set-cookie')!.split(';')[0];
@@ -73,9 +64,9 @@ export function baseData(overrides: Partial<Data> = {}): Data {
};
}
/** New browser context = a different device/person, with its own IP and frozen clock. */
/** New browser context = a different device/person, with its own frozen clock. */
export async function newClient(browser: Browser, baseURL = 'http://localhost:3100') {
const context = await browser.newContext({ baseURL, extraHTTPHeaders: { 'X-Forwarded-For': randomIp() } });
const context = await browser.newContext({ baseURL });
const page = await context.newPage();
await page.clock.setFixedTime(NOW);
return { context, page };
@@ -106,9 +97,6 @@ export const test = base.extend<{ user: Creds; cleanup: void }>({
},
{ auto: true },
],
extraHTTPHeaders: async ({}, use) => {
await use({ 'X-Forwarded-For': randomIp() });
},
page: async ({ page }, use) => {
await page.clock.setFixedTime(NOW);
await use(page);