remove species tab from locality details, and add skips to tests

This commit is contained in:
juhanikat
2026-09-28 14:27:07 +03:00
parent 31d1306df1
commit ccefe118f1
2 changed files with 11 additions and 12 deletions
+11 -7
View File
@@ -4,12 +4,16 @@ before('Reset database', () => {
const buildLocalityName = (base = 'Bugat') => `${base} ${Date.now()}-${Math.floor(Math.random() * 1e6)}` const buildLocalityName = (base = 'Bugat') => `${base} ${Date.now()}-${Math.floor(Math.random() * 1e6)}`
// TODO: these tests are obsolete now that the Species tab has been removed from Locality details.
// I'm leaving the code here in case it has to be re-enabled in the future.
// Some of these tests should also probably be modified and copied over to the Occurrence tab testing.
describe('Adding species in Locality -> Species tab for an existing locality', () => { describe('Adding species in Locality -> Species tab for an existing locality', () => {
beforeEach('Login as admin with session caching', () => { beforeEach('Login as admin with session caching', () => {
cy.loginWithSession('testSu') cy.loginWithSession('testSu')
}) })
it('works with valid, unique species', () => { it.skip('works with valid, unique species', () => {
cy.visit(`/locality/20920?tab=2`) cy.visit(`/locality/20920?tab=2`)
cy.contains('Lantian-Shuijiazui') cy.contains('Lantian-Shuijiazui')
cy.get('[id=edit-button]').click() cy.get('[id=edit-button]').click()
@@ -29,7 +33,7 @@ describe('Adding species in Locality -> Species tab for an existing locality', (
cy.contains('somespecies') cy.contains('somespecies')
}) })
it('works through "copy species taxonomy" button', () => { it.skip('works through "copy species taxonomy" button', () => {
cy.visit(`/locality/20920?tab=2`) cy.visit(`/locality/20920?tab=2`)
cy.contains('Lantian-Shuijiazui') cy.contains('Lantian-Shuijiazui')
cy.get('[id=edit-button]').click() cy.get('[id=edit-button]').click()
@@ -46,7 +50,7 @@ describe('Adding species in Locality -> Species tab for an existing locality', (
cy.contains('newspecies') cy.contains('newspecies')
}) })
it('does not work with invalid species', () => { it.skip('does not work with invalid species', () => {
cy.visit(`/locality/20920?tab=2`) cy.visit(`/locality/20920?tab=2`)
cy.contains('Lantian-Shuijiazui') cy.contains('Lantian-Shuijiazui')
cy.get('[id=edit-button]').click() cy.get('[id=edit-button]').click()
@@ -62,7 +66,7 @@ describe('Adding species in Locality -> Species tab for an existing locality', (
cy.contains('Order must not contain any spaces, unless the value is "incertae sedis".') cy.contains('Order must not contain any spaces, unless the value is "incertae sedis".')
}) })
it('does not work if the species has already been added', () => { it.skip('does not work if the species has already been added', () => {
cy.visit(`/locality/20920?tab=2`) cy.visit(`/locality/20920?tab=2`)
cy.contains('Lantian-Shuijiazui') cy.contains('Lantian-Shuijiazui')
cy.get('[id=edit-button]').click() cy.get('[id=edit-button]').click()
@@ -107,7 +111,7 @@ describe('Adding species in Locality -> Species tab for an existing locality', (
cy.contains('The taxon already exists in the database.') cy.contains('The taxon already exists in the database.')
}) })
it('does not work with species with invalid taxonomic order', () => { it.skip('does not work with species with invalid taxonomic order', () => {
cy.visit(`/locality/20920?tab=2`) cy.visit(`/locality/20920?tab=2`)
cy.contains('Lantian-Shuijiazui') cy.contains('Lantian-Shuijiazui')
cy.get('[id=edit-button]').click() cy.get('[id=edit-button]').click()
@@ -145,7 +149,7 @@ describe('Adding species in Locality -> Species tab for an existing locality', (
cy.contains('Genus Amblycoptus belongs to family Soricidae, not Bovidae.') cy.contains('Genus Amblycoptus belongs to family Soricidae, not Bovidae.')
}) })
it('minus action only marks the clicked species row as removed', () => { it.skip('minus action only marks the clicked species row as removed', () => {
cy.visit(`/locality/20920?tab=2`) cy.visit(`/locality/20920?tab=2`)
cy.contains('Lantian-Shuijiazui') cy.contains('Lantian-Shuijiazui')
cy.get('[id=edit-button]').click() cy.get('[id=edit-button]').click()
@@ -178,7 +182,7 @@ describe('Adding species in Locality -> Species tab for an existing locality', (
}) })
}) })
it('does not work through "copy species taxonomy" button if nothing is changed', () => { it.skip('does not work through "copy species taxonomy" button if nothing is changed', () => {
cy.visit(`/locality/20920?tab=2`) cy.visit(`/locality/20920?tab=2`)
cy.contains('Lantian-Shuijiazui') cy.contains('Lantian-Shuijiazui')
cy.get('[id=edit-button]').click() cy.get('[id=edit-button]').click()
@@ -15,7 +15,6 @@ import { LocalityTab } from './Tabs/LocalityTab'
import { MuseumTab } from './Tabs/MuseumTab' import { MuseumTab } from './Tabs/MuseumTab'
import { OccurrencesTab } from './Tabs/OccurrencesTab' import { OccurrencesTab } from './Tabs/OccurrencesTab'
import { ProjectTab } from './Tabs/ProjectTab' import { ProjectTab } from './Tabs/ProjectTab'
import { SpeciesTab } from './Tabs/SpeciesTab'
import { TaphonomyTab } from './Tabs/TaphonomyTab' import { TaphonomyTab } from './Tabs/TaphonomyTab'
import { EditDataType, LocalityDetailsType, ValidationErrors } from '@/shared/types' import { EditDataType, LocalityDetailsType, ValidationErrors } from '@/shared/types'
import { validateLocality, validateLocalityFields } from '@/shared/validators/locality' import { validateLocality, validateLocalityFields } from '@/shared/validators/locality'
@@ -115,10 +114,6 @@ export const LocalityDetails = ({
title: 'Locality', title: 'Locality',
content: <LocalityTab />, content: <LocalityTab />,
}, },
{
title: 'Species',
content: <SpeciesTab />,
},
{ {
title: occurrenceLabels.plural, title: occurrenceLabels.plural,
content: <OccurrencesTab />, content: <OccurrencesTab />,