From 9459dc805844f6b5f61bc04c6e933e1bcdd98769 Mon Sep 17 00:00:00 2001
From: Kari Lintulaakso <kari.lintulaakso@gmail.com>
Date: Mon, 27 Apr 2026 15:41:24 +0300
Subject: [PATCH] DwC-A localities: only concat requested fields

---
 .../services/dwcArchiveExportLocalities.ts    | 140 +++++++++++-------
 .../functionality/dwc_export_localities.md    |   7 +-
 2 files changed, 90 insertions(+), 57 deletions(-)

diff --git a/backend/src/services/dwcArchiveExportLocalities.ts b/backend/src/services/dwcArchiveExportLocalities.ts
index 8beb99d8..ab826c50 100644
--- a/backend/src/services/dwcArchiveExportLocalities.ts
+++ b/backend/src/services/dwcArchiveExportLocalities.ts
@@ -383,6 +383,90 @@ const LOCALITY_MEASUREMENT_MAPPINGS: Array<{
     // TODO(#1150): Add controlled vocabulary / description.
     measurementMethod: '',
   },
+  {
+    field: 'rock_type',
+    measurementType: 'rock type',
+    measurementUnit: '',
+    // TODO(#1150): Add field description / controlled vocabulary.
+    measurementMethod: '',
+  },
+  {
+    field: 'rt_adj',
+    measurementType: 'rock type adjective',
+    measurementUnit: '',
+    // TODO(#1150): Add field description / controlled vocabulary.
+    measurementMethod: '',
+  },
+  {
+    field: 'lith_comm',
+    measurementType: 'lithology comment',
+    measurementUnit: '',
+    // TODO(#1150): Add field description / controlled vocabulary.
+    measurementMethod: '',
+  },
+  {
+    field: 'sed_env_1',
+    measurementType: 'sedimentary environment 1',
+    measurementUnit: '',
+    // TODO(#1150): Add field description / controlled vocabulary.
+    measurementMethod: '',
+  },
+  {
+    field: 'sed_env_2',
+    measurementType: 'sedimentary environment 2',
+    measurementUnit: '',
+    // TODO(#1150): Add field description / controlled vocabulary.
+    measurementMethod: '',
+  },
+  {
+    field: 'event_circum',
+    measurementType: 'event circumstances',
+    measurementUnit: '',
+    // TODO(#1150): Add field description / controlled vocabulary.
+    measurementMethod: '',
+  },
+  {
+    field: 'se_comm',
+    measurementType: 'sedimentary environment comment',
+    measurementUnit: '',
+    // TODO(#1150): Add field description / controlled vocabulary.
+    measurementMethod: '',
+  },
+  {
+    field: 'depo_context1',
+    measurementType: 'depositional context 1',
+    measurementUnit: '',
+    // TODO(#1150): Add field description / controlled vocabulary.
+    measurementMethod: '',
+  },
+  {
+    field: 'depo_context2',
+    measurementType: 'depositional context 2',
+    measurementUnit: '',
+    // TODO(#1150): Add field description / controlled vocabulary.
+    measurementMethod: '',
+  },
+  {
+    field: 'depo_context3',
+    measurementType: 'depositional context 3',
+    measurementUnit: '',
+    // TODO(#1150): Add field description / controlled vocabulary.
+    measurementMethod: '',
+  },
+  {
+    field: 'depo_context4',
+    measurementType: 'depositional context 4',
+    measurementUnit: '',
+    // TODO(#1150): Add field description / controlled vocabulary.
+    measurementMethod: '',
+  },
+  {
+    field: 'depo_comm',
+    measurementType: 'depositional context comment',
+    measurementUnit: '',
+    // TODO(#1150): Add field description / controlled vocabulary.
+    measurementMethod: '',
+  },
   {
     field: 'chron',
     measurementType: 'chron',
@@ -516,62 +600,6 @@ export const mapLocalityToMeasurementRows = (locality: LocalityForExport): Local
     })
   }
 
-  const lithologyValue = concatMeaningful([locality.rock_type, locality.rt_adj, locality.lith_comm])
-  if (lithologyValue) {
-    rows.push({
-      taxonID,
-      measurementID: buildLocalityMeasurementId(lid, 'lithology'),
-      parentMeasurementID: '',
-      measurementType: 'lithology',
-      verbatimMeasurementType: 'rock_type|rt_adj|lith_comm',
-      measurementValue: lithologyValue,
-      measurementUnit: '',
-      // TODO(#1150): Add field description.
-      measurementMethod: '',
-    })
-  }
-
-  const depositionalContextValue = concatMeaningful([
-    locality.depo_context1,
-    locality.depo_context2,
-    locality.depo_context3,
-    locality.depo_context4,
-    locality.depo_comm,
-  ])
-  if (depositionalContextValue) {
-    rows.push({
-      taxonID,
-      measurementID: buildLocalityMeasurementId(lid, 'depositional_context'),
-      parentMeasurementID: '',
-      measurementType: 'depositional context',
-      verbatimMeasurementType: 'depo_context1|depo_context2|depo_context3|depo_context4|depo_comm',
-      measurementValue: depositionalContextValue,
-      measurementUnit: '',
-      // TODO(#1150): Add field description.
-      measurementMethod: '',
-    })
-  }
-
-  const sedimentaryEnvironmentValue = concatMeaningful([
-    locality.sed_env_1,
-    locality.sed_env_2,
-    locality.event_circum,
-    locality.se_comm,
-  ])
-  if (sedimentaryEnvironmentValue) {
-    rows.push({
-      taxonID,
-      measurementID: buildLocalityMeasurementId(lid, 'sedimentary_environment'),
-      parentMeasurementID: '',
-      measurementType: 'sedimentary environment',
-      verbatimMeasurementType: 'sed_env_1|sed_env_2|event_circum|se_comm',
-      measurementValue: sedimentaryEnvironmentValue,
-      measurementUnit: '',
-      // TODO(#1150): Add field description.
-      measurementMethod: '',
-    })
-  }
-
   const sedimentaryStructures = locality.now_ss
     .map(row => row.sed_struct)
     .filter(value => isMeaningfulString(value))
diff --git a/documentation/functionality/dwc_export_localities.md b/documentation/functionality/dwc_export_localities.md
index 6ca1b435..97148efd 100644
--- a/documentation/functionality/dwc_export_localities.md
+++ b/documentation/functionality/dwc_export_localities.md
@@ -56,7 +56,12 @@ Each emitted row has:
 - `parentMeasurementID` is used for the age hierarchy:
   - `NOW:LOC:<lid>:age` (parent) → `max_age` / `min_age`
   - `bfa_*`, `*_abs`, `frac_*` link to the relevant `max_age` / `min_age`
-- `verbatimMeasurementType` = original DB field name (or `|`-joined source field list for concatenated group rows)
+- `verbatimMeasurementType` = original DB field name
+
+Concatenation rules (v1):
+
+- Locality synonyms are concatenated with `|` into a single `synonyms` measurement row.
+- Sedimentary Structure & Taphonomic Detail values are concatenated with `|` into a single measurement row.
 
 ## Admin-only