From 49b8bde03e854f3ba93e27a0e3eae7e43d215c26 Mon Sep 17 00:00:00 2001 From: Aaro Koivukangas Date: Thu, 10 Aug 2023 16:46:00 +0300 Subject: [PATCH] removed rubocop warning with cool syntastic sugar :D --- app/models/concerns/rating_average.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/models/concerns/rating_average.rb b/app/models/concerns/rating_average.rb index bad6243..f6af173 100644 --- a/app/models/concerns/rating_average.rb +++ b/app/models/concerns/rating_average.rb @@ -7,7 +7,7 @@ module RatingAverage elsif instance_of?(Brewery) # creates empty arrays for beers that have no ratings # + wraps the array in an array - ratings = beers.map { |b| b.ratings }.reject(&:blank?)[0] + ratings = beers.map(&:b.ratings).reject(&:blank?)[0] elsif instance_of?(User) ratings = self.ratings else @@ -16,14 +16,14 @@ module RatingAverage return 0 unless ratings.count > 0 - ratings.map { |r| r.score }.sum / ratings.count.to_f + ratings.map(&:r.score).sum / ratings.count.to_f end def count_ratings if instance_of?(Beer) || User ratings.count elsif instance_of?(Brewery) - beers.map { |b| b.ratings.count }.sum + beers.map(&:ratings.count).sum else raise "Wrong class type for counting ratings, #{self.class}" end